Move all register allocations out of the asm_href loop #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register allocations inline while emitting HREF loop code is hazardous because a spill would mean a load or remat generated in the loop body.
|
@siddhesh Merged with the extra commit log note "This work was sponsored by OpenResty Inc." :) Many thanks! |
|
Just for the record, this bug led to Lua if statements not entered even when the condition is true when fuzzing our ylang compiler on aarch64 centos 7. And random seed numbers had to be used to feed the API function jit.prngstate to reproduce this more frequently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register allocations inline while emitting HREF loop code is hazardous
because a spill would mean a load or remat generated in the loop body.