maage: fix: use memchr to scan ngx_string #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
==13043==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x621000074100 at pc 0x563ba79d56c9 bp 0x7ffec6e4cf70 sp 0x7ffec6e4c720 READ of size 4097 at 0x621000074100 thread T0
zhuizhuhaomeng
requested changes
Jan 9, 2022
| @@ -514,7 +514,8 @@ ngx_http_eval_parse_param(ngx_http_request_t *r, ngx_http_eval_ctx_t *ctx, | |||
| ngx_str_t name; | |||
| ngx_str_t value; | |||
|
|
|||
| p = (u_char *) ngx_strchr(param->data, '='); | |||
| /* param->data is not \0 terminated */ | |||
| p = (u_char *) memchr(param->data, '=', param->len); | |||
There was a problem hiding this comment.
Suggested change
| p = (u_char *) memchr(param->data, '=', param->len); | |
| p = (u_char *) ngx_strlchr(param->data, param->data + param->len, '='); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field is not \0 terminated.
==13043==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x621000074100 at pc 0x563ba79d56c9 bp 0x7ffec6e4cf70 sp 0x7ffec6e4c720
READ of size 4097 at 0x621000074100 thread T0