feature: add '--- curl_options' and '--- curl_protocol' section #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuizhuhaomeng
approved these changes
Sep 26, 2021
|
Hi @woodgear, documentation is needed here |
|
The Test::Nginx document is in pod format (check https://perldoc.perl.org/perlpod for help), and the documentation for these two new options can be just added to the current .pm file like other options |
woodgear
force-pushed
the
feature/more-curl-section
branch
from
d11b980
to
aa36c13
Compare
|
update to add doc。 not sure I'm doing it right. |
xiaocang
requested changes
Sep 27, 2021
lib/Test/Nginx/Socket.pm
Outdated
| @@ -2993,6 +3003,14 @@ C<--- raw_request>. | |||
|
|
|||
| See also the L<TEST_NGINX_USE_HTTP2> system environment for the "http2" test mode. | |||
|
|
|||
| =head2 curl_options | |||
|
|
|||
| add curl options when use 'curl' to send request. | |||
There was a problem hiding this comment.
Add extra command line options when using 'curl' to send request should be better here
There was a problem hiding this comment.
And, you can give a useful example here
lib/Test/Nginx/Socket.pm
Outdated
|
|
||
| =head2 curl_protocol | ||
|
|
||
| set protocol such as http/https when use 'curl' to send request. |
There was a problem hiding this comment.
Set protocol (such as http/https) when sending request using 'curl' may be better here
woodgear
force-pushed
the
feature/more-curl-section
branch
from
aa36c13
to
5047fb2
Compare
|
update |
xiaocang
requested changes
Sep 27, 2021
… could combine with '--- http2' to construct a request by curl.
woodgear
force-pushed
the
feature/more-curl-section
branch
from
5047fb2
to
cf5d91d
Compare
|
when will this pr merge? |
|
Merged with minor tweaks, thanks for the contribution! diff --git a/lib/Test/Nginx/Socket.pm b/lib/Test/Nginx/Socket.pm
index 6901192..398fbd8 100644
--- a/lib/Test/Nginx/Socket.pm
+++ b/lib/Test/Nginx/Socket.pm
@@ -3011,7 +3011,7 @@ Set protocol (such as http/https) when sending request using 'curl'.
Add extra command line options when using 'curl' to send request.
-Below example will send https request via curl:
+Below is an example for sending an insecure https request using 'curl':
--- http2
--- curl_options: -k |
|
cool ^_^. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: add '--- curl_options' and '--- curl_protocol' section which could combine with '--- http2' to construct a request by curl.