Do not parameterize throwable argument

Fixes #131
openrewrite · Feb 19, 2024 · b2b39d5 · b2b39d5
1 parent 886d914
commit b2b39d5
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/main/java/org/openrewrite/java/logging/ParameterizedLogging.java b/src/main/java/org/openrewrite/java/logging/ParameterizedLogging.java
@@ -96,6 +96,8 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
                                 .contextSensitive()
                                 .build()
                                 .apply(new Cursor(getCursor().getParent(), m), m.getCoordinates().replaceArguments(), newArgList.toArray());
+                    } else if (logMsg instanceof J.Identifier && TypeUtils.isAssignableTo("java.lang.Throwable", logMsg.getType()) ) {
+                        return m;
                     } else if (!TypeUtils.isString(logMsg.getType()) && logMsg.getType() instanceof JavaType.Class) {
                         StringBuilder messageBuilder = new StringBuilder("\"{}\"");
                         m.getArguments().forEach(arg -> messageBuilder.append(", #{any()}"));

diff --git a/src/test/java/org/openrewrite/java/logging/ParameterizedLoggingTest.java b/src/test/java/org/openrewrite/java/logging/ParameterizedLoggingTest.java
@@ -400,6 +400,30 @@ static void method(Logger logger, String numberString) {
         );
     }
 
+    @Test
+    @Issue("https://github.com/openrewrite/rewrite-logging-frameworks/issues/131")
+    void throwableSingleParameter() {
+        rewriteRun(
+          spec -> spec.recipe(new ParameterizedLogging("org.apache.logging.log4j.Logger error(..)", false)),
+          //language=java
+          java(
+            """
+              import org.apache.logging.log4j.Logger;
+
+              class Test {
+                  static void method(Logger logger, String numberString) {
+                      try {
+                          Integer i = Integer.valueOf(numberString);
+                      } catch (Exception e) {
+                          logger.error(e);
+                      }
+                  }
+              }
+              """
+          )
+        );
+    }
+
     @Issue("https://github.com/openrewrite/rewrite-logging-frameworks/issues/58")
     @Test
     void methodInvocationReturnTypeIsString() {