Fix: Loggers should be named for their enclosing classes should not replace calls to getClass() #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not remove `getClass()` when creating logger if the enclosing class is abstract
timtebeek
approved these changes
May 6, 2023
timtebeek
reviewed
May 6, 2023
src/test/java/org/openrewrite/java/logging/slf4j/LoggersNamedForEnclosingClassTest.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
May 6, 2023
|
Great! Thanks for the quick work on this; will merge as soon as the build completes. After your first contribution I won't have to approve your CI runs anymore, which also helps speed up the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #101
Do not remove
getClass()when creating logger if the enclosing class is abstract