Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Guava Optional with JDK Optional #202
Replace Guava Optional with JDK Optional #202
Changes from 5 commits
a1cc80b
691f418
ccdd601
5ecbb24
31323c7
e9b8f5e
98739f2
0366a26
3e46b32
3852663
2d5f1bd
968a4bc
5913b4d
06a5a8d
bb48f4c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this is actually the problem of the
![image](https://user-images.githubusercontent.com/408765/227859803-22d4752d-eef6-4dbd-b79b-8750ca0af6e0.png)
ChangeType
recipe (I will investigate this further, when I find time), but as you can see in the following screenshot from the debugger, the type attribution of theoptional
parameter refers to the correct new type, but as its owner still refers to the oldJavaType.Method
object: