Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Framework 6.0 recipe with migration for Spring Assert #522

Merged
merged 3 commits into from
May 8, 2024

Conversation

pativa
Copy link
Contributor

@pativa pativa commented May 7, 2024

What's changed?

Added a base recipe for migrating to Spring Framework 6.
This is not a complete migration, but can serve as a place to put Spring-related migrations necessary (as opposed to changes related to only Spring Boot).

What's your motivation?

#521

Anything in particular you'd like reviewers to focus on?

I copied the format from the earlier UpgradeSpringFramework_5_3.

Any additional context

I have tested the changes under MigrateSpringAssert in our internal migration and it seems to work fine.
I have taken the literal text added from the Spring class and reformatted them a bit.

Ideally, the message contain variable name but that would be a harder change to write automatically.
Usage of this is probably not too common anyway as the functions have been deprecated for a long time.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

* Only includes a migration for removed methods in `org.springframework.util.Assert` for now
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see; thanks a lot!

@timtebeek timtebeek merged commit eddf42e into openrewrite:main May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-3.0 recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants