Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AssertNotEqualsToAssertThat and better message handling. #15

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Adding AssertNotEqualsToAssertThat and better message handling. #15

merged 1 commit into from
Dec 10, 2020

Conversation

tkvangorder
Copy link
Contributor

No description provided.

@tkvangorder tkvangorder mentioned this pull request Dec 7, 2020
Closed
12 tasks
@tkvangorder tkvangorder added the enhancement New feature or request label Dec 7, 2020
@tkvangorder
Copy link
Contributor Author

This PR is predicated on fixes made to rewrite in this PR: openrewrite/rewrite#106

@tkvangorder tkvangorder force-pushed the assertj-messaging branch 3 times, most recently from 947d30f to 70b2d45 Compare December 10, 2020 17:37
@tkvangorder
Copy link
Contributor Author

@sambsnyd @SofiaBrittoSchwartz This is now ready for review.

@jkschneider jkschneider self-requested a review December 10, 2020 20:35
sambsnyd
sambsnyd approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@sambsnyd sambsnyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work

jkschneider
jkschneider approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@jkschneider jkschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkschneider jkschneider merged commit ca93760 into master Dec 10, 2020
@jkschneider jkschneider deleted the assertj-messaging branch December 10, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkschneider jkschneider jkschneider approved these changes

@sambsnyd sambsnyd sambsnyd approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tkvangorder @jkschneider @sambsnyd