Cucumber annotation to suite

[timtebeek]

Not sure why I can't replace a single annotation with two annotations from a single template like this. 🤔

[pway99]

In general dependencies necessary for recipe testing should belong to the testRuntimeOnly group.

[pway99]

closed as completed by 50ba449

[pway99]

@timtebeek, when you have a chance it would be a good idea to add a maven project to the test, I ran out of steam today and did not fully track down the inital maven project configuration

@Test
void should_replace_cucumber_annotation_with_suite_with_selected_classpath_resource() {
rewriteRun(
        mavenProject("project",
                srcTestJava(
                        java("""
                            package com.example.app;
            
                            import io.cucumber.junit.platform.engine.Cucumber;
            
                            @Cucumber
                            public class CucumberJava8Definitions {
                            }
                            """,
                            """
                            package com.example.app;
            
                            import org.junit.platform.suite.api.SelectClasspathResource;
                            import org.junit.platform.suite.api.Suite;
            
                            @Suite
                            @SelectClasspathResource("com/example/app")
                            public class CucumberJava8Definitions {
                            }
                            """)
                ),
                pomXml(
                        """
                        <project>
                            <groupId>com.mycompany.app</groupId>
                            <artifactId>my-app</artifactId>
                            <version>1</version>
                        </project>
                        <dependencies>
                            ...
                        </dependencies>
                        """,
                        """
                        <project>
                            <groupId>com.mycompany.app</groupId>
                            <artifactId>my-app</artifactId>
                            <version>1</version>
                        </project>
                        <dependencies>
                            <dependency>
                                <groupId>org.junit.platform</groupId>
                                <artifactId>junit-platform-suite</artifactId>
                                <version>1.9.1</version>
                            <dependency>
                        </dependencies>
                        """)
        )
);
}

[pway99]

Hello @timtebeek and @mpkorstanje,
I had made an error in suggesting that the cucumber dependencies should be moved to the testRuntimeOnly class path and the JavaParser class-path references replaced with stubs. If you're interested here are the changes 5cd92db changes. Thanks again for your help on this one :)

[pway99]

On second thought, I decided to remove the maven changes from the test to avoid future test failures after the next junit-platform-suite release. 59c9c57

[timtebeek]

Awesome; thanks a lot for the help, especially throughout the various iterations around testing.
I could see the maven project tests indeed require frequent upgrades if we had left those in.
Perhaps in the future we can look at some form of version matching to not have to update those.

That makes #264 ready for a write up; I'll try to squeeze in both a blog and some release notes for Cucumber-JVM.

[pway99]

Yeah, that would be a nice feature. The maven test is very useful during the development cycle; I had an error in the dependency glob expression which might have gone unnoticed.