Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not use equals when comparing object identity #274

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Should not use equals when comparing object identity #274

merged 1 commit into from
Oct 20, 2022

Conversation

vandeven
Copy link
Contributor

fixes #273

tkvangorder
tkvangorder approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@tkvangorder tkvangorder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@tkvangorder tkvangorder merged commit 5e832a5 into openrewrite:main Oct 20, 2022
@tkvangorder tkvangorder added the bug Something isn't working label Oct 20, 2022
@tkvangorder tkvangorder added this to the 1.31.0 milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkvangorder tkvangorder tkvangorder approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.

AssertTrueComparisonToAssertEquals is not appropriate when comparing objects.
2 participants
@vandeven @tkvangorder