Add Kotlin support for JUnit recipes: UpdateBeforeAfterAnnotations #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preVisit instead of visitCompilationUnit.
…h new tests for kotlin
* Add Picnic AssertJ rules to AssertJ best practices * Include Picnic's JUnitToAssertJRulesRecipes in migration * Exclude `jakarta.xml.bind-api` from TimeFold * Move the exclude to rewrite-third-party
Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/kLJjXlflM?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <team@moderne.io>
… Mockito verify statement (openrewrite#530) * Ensure Jmockit expectations with no times or result transform to a mockito verify * Minor polish to text blocks * Make times, minTimes, maxTimes more flexible as it was originally so even if someone mistakenly puts times and minTimes together, it still migrates without issue --------- Co-authored-by: Tim te Beek <tim@moderne.io>
…penrewrite#532) * Ensure Jmockit expectations with no times or result transform to a mockito verify * Minor polish to text blocks * Make times, minTimes, maxTimes more flexible as it was originally so even if someone mistakenly puts times and minTimes together, it still migrates without issue * Add feature to enable migration of Jmockit Injectable annotation exactly as we are doing the Mocked annotation ie method parameter annotation as well as field annotation. Have moved all of the code from JMockitMockedVariableToMockito to JMockitAnnotationToMockito for code reuse. Also add the corresponding test cases and jmockit.yml file modification. * Use `@Option` instead of inheritance * Drop Option and just replace both variants * Update display name and description to match application --------- Co-authored-by: Tim te Beek <tim@moderne.io>
…h new tests for kotlin
…-cleanuprule' into feature/add-kotlin-support-junit-cleanuprule
amitojduggal
commented
Jun 20, 2024
src/test/java/org/openrewrite/java/testing/junit5/AddParameterizedTestAnnotationTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jun 20, 2024
src/test/java/org/openrewrite/java/testing/junit5/AddParameterizedTestAnnotationTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jun 20, 2024
src/test/java/org/openrewrite/java/testing/junit5/UpdateBeforeAfterAnnotationsTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jun 20, 2024
src/test/java/org/openrewrite/java/testing/junit5/UpdateBeforeAfterAnnotationsTest.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Great work here @amitojduggal ! With some small adjustments to the tests I think we cna get this through quickly. Really appreciate the work here to make the recipes work for Kotlin.
…AfterAnnotationsTest.java Co-authored-by: Tim te Beek <timtebeek@gmail.com>
…We can tackle the issues and add tests separately if we see bug in workflows.
|
Its done @timtebeek , i addressed the review comments. Thanks for the feedback |
timtebeek
approved these changes
Jun 23, 2024
There was a problem hiding this comment.
Great to see @amitojduggal ! Thanks for applying that review feedback so quickly too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Would like to make the recipes to work both with Java and Kotlin.
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@timtebeek @knutwannheden
Have you considered any alternatives or workarounds?
Any additional context
Checklist