edge cases for ReloadableJava17JavadocVisitor

[bnaudts]

What version of OpenRewrite are you using?

I am using

• OpenRewrite 8.9.0-SNAPSHOT, main branch, commit 0d884d4

How are you running OpenRewrite?

In IntelliJ, but also using the latest Gradle plugin, latest SNAPSHOT version.

What is the smallest, simplest way to reproduce the problem?

The following are a number of tests that can be inserted into org.openrewrite.java.tree.JavadocTest.
Each detail a minor JavaDoc parsing issue.

    @Test
    void unicodeAmpersand() {
        rewriteRun(
          java("""
            package com.foo;

             /**
              * {@code
              * \\u0040Override
              * public void method() {
              * }
              */
             @SuppressWarnings
             class Bar { }
             """)
        );
    }

    @Test
    void unicodeAccent() {
        rewriteRun(
          java("""
            package com.foo;

             /**
              * @author Xx\\u00e9
             */
             class Bar { }
             """)
        );
    }

    @Test
    void badlyClosedXmlTags() {
        rewriteRun(
          java("""
            package com.foo;
            /**
             <!--Optional:->
             <urn:portalId>?</urn:portalId-->
            */

            class Bar { }
            """)
        );
    }

    @Test
    void unicodeSpace() {
        rewriteRun(java("""
          package com.foo;

          /**
           * Strip characters that are not allowed in an XML document : those below ASCII 32 (HEX 20 -> in java < '\\u0020')
           */
          public class Bar { }
          """));
    }

    @Test
    void splitAtDot() {
        rewriteRun(java("""
          package com.foo;
          	/**
          	 * @see a.b.Type#method(a.b.c.
          	 * d.Type)
          	 */
          class Bar { }
          """));
    }

    @Test
    void combinedCommentsWithoutSpace() {
        // solved by adding a space between */ and /*
        rewriteRun(java("""
          package com.foo;
          class Bar {
          	/**
          	 * xx
          	 *//*
               void method() {
               }*/
          }
          """));
    }

    @Test
    void spaceStarAfterStartOfJavaDoc() {
        // remove the * after /**
        rewriteRun(java("""
          package com.foo;
           /**	 *
            * @author x
            */
          class Bar { }
          """));
    }

    @Test
    void bracketNotClosedInJavaDoc() {
        rewriteRun(java("""
          package com.foo;
          	/**
          	 * {@link Foo#method(int, int) xyz
          	 * @abc
          	 */
          class Bar { }
          """));
    }

What did you expect to see?

A green test.
I have no particular interest in exactly how the parser solves the issue (i.e., by ignoring, or correcting), just that it does not fail on the whole file.

What did you see instead?

A red test, i.e., parsing stops with an error.

[timtebeek]

Thanks a lot for these detailed reports @bnaudts ! Really helpful to have them in a format we can directly run.I'll see if we can fit in a fix of these issues, as indeed this should not break parsing your project.