Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing swallowed compilation errors due to package name / path mismatch when using JavaParser's dependsOn. #4040

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

ammachado
Copy link
Contributor

What's changed?

This PR provides path for classes that are being used on a JavaParser's dependsOn method. Currently the compiler generates compilation errors due to package name / path mismatch, and the errors are swallowed.

What's your motivation?

This was identified while #4030

Anything in particular you'd like reviewers to focus on?

No

Anyone you would like to review specifically?

No

Have you considered any alternatives or workarounds?

No

Any additional context

No

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@ammachado
Copy link
Contributor Author

To view the error generated, put a breakpoint on com.sun.tools.javac.util.Log report(JCDiagnostic)

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Nice to see how you applied the minimal change needed for this fix. :)

@timtebeek timtebeek merged commit af5abce into main Feb 24, 2024
1 check passed
@timtebeek timtebeek deleted the javaparser-swallow-errors-using-dependsOn branch February 24, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants