Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeParentPom's property-preservation now checks the resolved new p… #4143

Merged
merged 1 commit into from Apr 19, 2024

Conversation

nmck257
Copy link
Collaborator

@nmck257 nmck257 commented Apr 19, 2024

…arent (instead of unresolved new parent pom) when determining what properties will be available

What's changed?

see title

What's your motivation?

The new test case would previously fail, having added junit.version to the pom's properties

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

this is mostly a tweak on @sambsnyd 's recent code in this recipe

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

…arent (instead of unresolved new parent pom) when determining what properties will be available
@sambsnyd sambsnyd merged commit 0324a3c into main Apr 19, 2024
1 check passed
@sambsnyd sambsnyd deleted the bugfix/ChangeParentPom branch April 19, 2024 20:34
@sambsnyd
Copy link
Member

Thanks @nmck257 !

sambsnyd pushed a commit that referenced this pull request Apr 29, 2024
…arent (instead of unresolved new parent pom) when determining what properties will be available (#4143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants