[arci] Change the wait logic #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, if the timeout was 10 sec, the smallest wait rate was 1 Hz. It means that even if the sent trajectory was very short (like 10msec), it waits 1sec at least. By this change the unit duration is set to 10msec. (I'm not sure that it is enough small) It means the smallest sleep is 10 msec always, and nothing to do with the timeout sec.
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 19.72% 19.77% +0.05%
==========================================
Files 73 73
Lines 3990 3994 +4
Branches 899 900 +1
==========================================
+ Hits 787 790 +3
Misses 2935 2935
- Partials 268 269 +1
Continue to review full report at Codecov.
|
mitsuharu-kojima
approved these changes
Feb 2, 2021
9 tasks
mitsuharu-kojima
added a commit
that referenced
this pull request
Feb 4, 2021
mitsuharu-kojima
added a commit
that referenced
this pull request
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108
Before this change, if the timeout was 10 sec,
the smallest wait rate was 1 Hz (10 / 10 = 1).
It means that even if the sent trajectory was very short (like 10msec),
it waits 1sec at least.
By this change the unit duration is set to 10msec.
(I'm not sure that it is enough small (can be 1msec, but it increase the cost))
It means the smallest sleep is 10 msec always, and nothing to
do with the timeout sec now.