Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openrr-gui] Add text input to set duration and improve error handling about text input #210

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Feb 26, 2021

cc #101

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #210 (8204409) into main (ffc82d7) will decrease coverage by 0.60%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   20.86%   20.26%   -0.61%     
==========================================
  Files          76       76              
  Lines        4241     4367     +126     
  Branches      952      973      +21     
==========================================
  Hits          885      885              
- Misses       3037     3163     +126     
  Partials      319      319              
Impacted Files Coverage Δ
openrr-gui/src/joint_position_sender.rs 0.00% <0.00%> (ø)
openrr-gui/src/style.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc82d7...8204409. Read the comment docs.

@taiki-e
Copy link
Contributor Author

taiki-e commented Feb 26, 2021

openrr-gui-3.mov

@taiki-e taiki-e marked this pull request as ready for review February 26, 2021 11:30
@taiki-e taiki-e merged commit a3f1aa6 into main Mar 1, 2021
@taiki-e taiki-e deleted the taiki-e/gui-text-input branch March 1, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants