[arci-ros2] Add arci-ros2 (only MoveBase trait) #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #291 +/- ##
==========================================
+ Coverage 42.57% 42.84% +0.26%
==========================================
Files 80 82 +2
Lines 5085 5112 +27
==========================================
+ Hits 2165 2190 +25
- Misses 2920 2922 +2
Continue to review full report at Codecov.
|
OTL
commented
May 11, 2021
Comment on lines
+30
to
+32
| source /opt/ros/foxy/setup.bash | ||
| # for test of arci-ros (roscore, rostopic) | ||
| source /opt/ros/melodic/setup.bash | ||
| cargo +nightly-2021-03-04 tarpaulin --verbose --all-features --workspace --out Xml | ||
| source /opt/ros/noetic/setup.bash |
There was a problem hiding this comment.
coverage on ubuntu20.04 (noetic/foxy) only.
melodic is excluded.
taiki-e
reviewed
May 11, 2021
OTL
added a commit
that referenced
this pull request
May 11, 2021
Co-authored-by: Taiki Endo <te316e89@gmail.com>
OTL
added a commit
that referenced
this pull request
May 11, 2021
Co-authored-by: Taiki Endo <te316e89@gmail.com>
* initial implement using r2r * cmd_vel client
It should not support ROS2 as default because it requires ros2 foxy is installed.
* arci-ros2 is built only ros2 feature is enabled. * Use openrr-coverage-ci:ros2 tag for coverage
Switch source order (ros2->ros1)
Co-authored-by: Taiki Endo <te316e89@gmail.com>
|
r2r is broken now. I'm working on it. |
|
r2r is fixed. They are using Rolling (the latest (unstable?) distro for ROS2) instead of foxy. |
mitsuharu-kojima
approved these changes
May 20, 2021
taiki-e
approved these changes
May 20, 2021
OTL
added a commit
that referenced
this pull request
May 20, 2021
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires ROS2 Foxy (Ubuntu 20.04).