Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openrr-gui] Use iced_style_config #663

Merged
merged 1 commit into from
Aug 10, 2022
Merged

[openrr-gui] Use iced_style_config #663

merged 1 commit into from
Aug 10, 2022

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Aug 5, 2022

cc #101

refs: https://github.com/taiki-e/iced_style_config

Resolves the following TODO:

// TODO: It's painful to recompile this crate every time I change the style.
// So remove and replace with https://github.com/taiki-e/iced_style_config or alternatives.

It also supports hot reloading of style sheets. This is useful for adjusting styles during development.

gui.mov

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #663 (2936913) into main (4ce27af) will increase coverage by 0.95%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
+ Coverage   59.07%   60.03%   +0.95%     
==========================================
  Files         117      117              
  Lines       13704    13486     -218     
==========================================
  Hits         8096     8096              
+ Misses       5608     5390     -218     
Impacted Files Coverage Δ
openrr-apps/src/bin/joint_position_sender.rs 25.00% <0.00%> (-1.09%) ⬇️
openrr-apps/src/bin/velocity_sender.rs 28.57% <0.00%> (-1.43%) ⬇️
openrr-gui/src/error.rs 0.00% <ø> (ø)
openrr-gui/src/joint_position_sender.rs 0.00% <0.00%> (ø)
openrr-gui/src/style.rs 0.00% <0.00%> (ø)
openrr-gui/src/velocity_sender.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taiki-e taiki-e marked this pull request as ready for review August 8, 2022 11:02
@taiki-e taiki-e requested a review from OTL August 9, 2022 07:32
Copy link
Contributor

@OTL OTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh,great!

@taiki-e taiki-e merged commit 6b7f677 into main Aug 10, 2022
@taiki-e taiki-e deleted the taiki-e/gui-style branch August 10, 2022 05:05
@taiki-e taiki-e changed the title [openrr-gnu] Use iced_style_config [openrr-gui] Use iced_style_config Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants