Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable region coverage on codecov #812

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Enable region coverage on codecov #812

merged 1 commit into from
Apr 21, 2023

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Apr 3, 2023

https://github.com/taiki-e/cargo-llvm-cov/releases/tag/v0.5.12

Catch cases where some regions are covered and others are not covered in the same line. For example, if the case that returns Ok is tested, but the case that returns Err is not, the line is marked as partially covered.

Blocked on taiki-e/cargo-llvm-cov#252.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #812 (47c5ae6) into main (64d7790) will decrease coverage by 2.58%.
The diff coverage is n/a.

❗ Current head 47c5ae6 differs from pull request most recent head 3eb1dae. Consider uploading reports for the commit 3eb1dae to get more accurate results

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   65.49%   62.92%   -2.58%     
==========================================
  Files         111      111              
  Lines       14031    14031              
  Branches        0    14031   +14031     
==========================================
- Hits         9190     8829     -361     
+ Misses       4841     4790      -51     
- Partials        0      412     +412     

see 65 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taiki-e taiki-e marked this pull request as draft April 3, 2023 14:42
@taiki-e taiki-e force-pushed the taiki-e/cov branch 3 times, most recently from 24409a1 to e5a32d1 Compare April 7, 2023 06:03
@taiki-e taiki-e force-pushed the taiki-e/cov branch 2 times, most recently from 47c5ae6 to 3eb1dae Compare April 19, 2023 07:26
@taiki-e taiki-e marked this pull request as ready for review April 19, 2023 09:40
@taiki-e taiki-e requested a review from OTL April 19, 2023 09:40
Copy link
Contributor

@OTL OTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 6f5f76c into main Apr 21, 2023
19 of 20 checks passed
@taiki-e taiki-e deleted the taiki-e/cov branch April 21, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants