Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support replacing ROS package path by command line #176

Merged
merged 1 commit into from Oct 19, 2022

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Oct 19, 2022

  • Support replacing ROS package path to URL/path (--package-path option on native, package-path[] URL parameter on web). This allows the processing of ROS packages on systems where ROS is not installed, such as the web.
  • Support http/https for URDF path on native. This has already been supported for URDF path on web, and for mesh path on both native and web.

Examples

native:

cargo run -- https://raw.githubusercontent.com/ToyotaResearchInstitute/hsr_description/master/robots/hsrb4s.obj.urdf --package-path hsr_meshes=https://raw.githubusercontent.com/ToyotaResearchInstitute/hsr_meshes/master

web:

http://localhost:8080/?urdf=https://raw.githubusercontent.com/ToyotaResearchInstitute/hsr_description/master/robots/hsrb4s.obj.urdf&package-path[]=hsr_meshes=https://raw.githubusercontent.com/ToyotaResearchInstitute/hsr_meshes/master

@taiki-e taiki-e requested a review from OTL October 19, 2022 06:54
@taiki-e taiki-e force-pushed the taiki-e/replace-package branch 5 times, most recently from 40ac4de to 12cbea5 Compare October 19, 2022 08:07
Copy link
Collaborator

@OTL OTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@taiki-e taiki-e merged commit 4591a23 into main Oct 19, 2022
@taiki-e taiki-e deleted the taiki-e/replace-package branch October 19, 2022 08:53
@taiki-e taiki-e mentioned this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants