Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

fix SSE connection release #69

Merged
merged 2 commits into from
Dec 13, 2017
Merged

fix SSE connection release #69

merged 2 commits into from
Dec 13, 2017

Conversation

hori-ryota
Copy link
Contributor

If client.ReceivePayload() closed, client will be not released forever.

@hori-ryota
Copy link
Contributor Author

If client.ReceivePayload() closed, it is correct to return the response status of success or failure?

Now, gRPC returns success but SSE failure

@stormcat24
Copy link
Contributor

successやろ

@hori-ryota hori-ryota force-pushed the feature/fix-sse-connection-release branch from 867afad to df0f220 Compare December 1, 2017 07:00
@hori-ryota hori-ryota force-pushed the feature/fix-sse-connection-release branch from df0f220 to 959c1af Compare December 2, 2017 08:43
@hori-ryota hori-ryota merged commit 36728f1 into master Dec 13, 2017
@hori-ryota hori-ryota deleted the feature/fix-sse-connection-release branch December 13, 2017 05:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hori-ryota @stormcat24