feat: Add a rudimentary ISARIC implementation #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenMaude
changed the title
StevenMaude
force-pushed
the
steve/isaric
branch
2 times, most recently
from
62d346b
to
3eae5a6
Compare
This is to facilitate some exploratory work to query the data with ehrQL. We don't yet really know what the columns look like, so let's work with them as all strings for now, and then later change the types, when we know more. (The linked data dictionary gives some indication, but it's not clear how the columns are represented in the database.) Descriptions taken from: https://github.com/isaric4c/wiki/blob/d6b87d59a277cf2f6deedeb5e8c1a970dbb970a3/ISARIC/CCP_REDCap_ISARIC_data_dictionary_codebook.pdf
StevenMaude
force-pushed
the
steve/isaric
branch
2 times, most recently
from
70c33e3
to
5c79d12
Compare
And update docs JSON.
StevenMaude
force-pushed
the
steve/isaric
branch
from
5c79d12
to
794eead
Compare
evansd
approved these changes
Feb 1, 2023
On Dave's suggestion; to make it easier to change in future.
We'll later probably want to actually cast these strings as actual types, but we need to initially know what the data looks like. If we guess, we're almost certainly going to get one or more columns wrong, and cause the query to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This facilitates access to the
ISARIC_Newtable in TPP for some preliminary work.We're not entirely sure how the data in there looks yet. When we know, we can substitute for more appropriate types and test examples.