-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove T1OO permission from several Bristol projects #4259
Comments
This issue would benefit from @CLStables's 👀. |
NOD discussed this today.1 @cewalters and @ptid1976 are going to make a decision; I'm going to move it off team-rex's board until they've done so. Footnotes |
Is this ticket still needed? |
This was an interim solution from before the T1OO deadline so I don't think it is needed anymore? |
Thank you. I'll close it now, although it can always been reopened if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our Bristol colleagues would like to remove the T1OO permission from several of their projects (see below). This is because they're submitting manuscripts now and expect reviewers to ask for follow-up analyses later, but the gap between submission and follow-up is likely to bridge the T1OO deadline. Rather than generate results for submission that include opt-outs, and then regenerate results for follow-up analysis that exclude opt-outs, it would be easier for our Bristol colleagues to generate/regenerate results that exclude opt-outs in both cases: now and later.
Removing the T1OO permission means editing
jobserver/permissions/t1oo.py
. Rather than removing the project ID fromPROJECTS_WITH_T1OO_PERMISSION
, we should instead comment out the project ID, and explain why it was removed.jobserver/permissions/t1oo.py
is owned by the IG team. Consequently, the resulting PR must be approved by a member of the IG team.The projects:
There are two accompanying Slack threads. In the first, @inglesp and @evansd help me understand how the T1OO permission is implemented. In the second, @venexia links to the projects. Thank you all for your help 🙂.
The text was updated successfully, but these errors were encountered: