Ignore jobs associated with unknown JobRequests #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variables were being set inside the loop but the logging happened outside, so only values from the last loop iteration were captured.
We're planning to update the job-runner sync protocol such that it syncs the state of all active jobs, where active now means those jobs which job-server thinks are active _and_ those which job-runner thinks are active. This should make the sync process even more robust against "non-standard" things happening (i.e. us fiddling with the state of jobs). This changes means that it's no longer a protocol violation for job-runner to tell job-server about a job which job-server didn't explicity ask about. If this happens (which I don't expect it to really) we should log it but not treat it as an error.
ghickman
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're planning to update the job-runner sync protocol such that it syncs the state of all active jobs, where active now means those jobs which job-server thinks are active and those which job-runner thinks are active. This should make the sync process even more robust against "non-standard" things happening (i.e. us fiddling with the state of jobs).
This changes means that it's no longer a protocol violation for job-runner to tell job-server about a job which job-server didn't explicitly ask about. If this happens (which I don't expect it to really) we should log it but not treat it as an error.