Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show most recently active workspaces on home/yours page #4165

Merged
merged 1 commit into from Mar 1, 2024
Merged

Show most recently active workspaces on home/yours page #4165

merged 1 commit into from Mar 1, 2024

Conversation

Jongmassey
Copy link
Contributor

Fixes #4125

@Jongmassey Jongmassey force-pushed the Jongmassey/Show-most-recently-active-workspaces-on-yours-page branch 2 times, most recently from f70e8e7 to 705368b Compare February 29, 2024 17:51
@Jongmassey
Copy link
Contributor Author

SQL query stats from debug toolbar on authenticated homepage

2ecfcda (before changes) - 29 queries in 60.33ms
7beaef9 (sort by most recent JobRequest) - 30 queries in 73ms
705368b (sort by most recent JobRequest, exclude those without)- 30 queries in 99ms
87b9844 (sort by most recent activity) - 30 queries in 76ms

@Jongmassey Jongmassey mentioned this pull request Mar 1, 2024
Closed
@Jongmassey Jongmassey force-pushed the Jongmassey/Show-most-recently-active-workspaces-on-yours-page branch from 87b9844 to a353ee2 Compare March 1, 2024 14:15
@Jongmassey Jongmassey marked this pull request as ready for review March 1, 2024 14:15
@Jongmassey Jongmassey requested a review from lucyb March 1, 2024 14:15
lucyb
lucyb approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@lucyb lucyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Django-ing!

tests/unit/jobserver/models/test_workspace.py Outdated Show resolved Hide resolved
@Jongmassey
Sort homepage workspaces by most recent activity
ad70af7 
i.e. workspace updated or jobrequest created
@Jongmassey Jongmassey force-pushed the Jongmassey/Show-most-recently-active-workspaces-on-yours-page branch from a353ee2 to ad70af7 Compare March 1, 2024 15:37
@Jongmassey Jongmassey merged commit 21f10ce into main Mar 1, 2024
8 checks passed
@Jongmassey Jongmassey deleted the Jongmassey/Show-most-recently-active-workspaces-on-yours-page branch March 1, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucyb lucyb lucyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show most recently active workspaces on yours page
2 participants
@Jongmassey @lucyb