Upgrade POI

[nelsongraca]

I wonder if it is possible to upgrade POI to 4.x I am currently evaluating using this library to convert some DOCX to PDF in a project but we already depend on v4 so this causes a conflict.

[esuomi]

FWIW, POI 4.x is also needed for JDK11 compatibility.

[angelozerr]

Thanks @esuomi for this info. In this case , I would like to avoid doing that since XDocReport works with Java5.

[nelsongraca]

@angelozerr so you will keep it without upgrading?

[angelozerr]

Jdt 11 is too young and there are aa lot People Who uses java 5. I prefer waiting That there are à Lot of People Who Use java 11 before switching to java 11. Please add +1or-1 to switch to java 11

[nelsongraca]

I'm using POI 4.x on JDK8 I dare to say that POI4.x adds support for JDK11, from what @esuomi said it does not imply that other versions support is dropped. As you might be aware except a very small set of things the JDK has been backwards compatible.

[nelsongraca]

I would also like to add that without the POI upgrade I will have to fork the project in order to be able to use it, and I would like to avoid that.

[esuomi]

@angelozerr Technically POI 4.x is needed when going beyond Java 8, I mentioned JDK11 just because that's the latest&greatest. A lot of libraries skipped support for Java 9 and 10 because of all the module changes etc. which made the interim versions not that important. Additionally now that Oracle requires money for Java 8 SE installations and JDK8 is EOL, the actual version that people are now migrating to is JDK11.

[angelozerr]

it does not imply that other versions support is dropped

Sorry I have read too quickly. @nelsongraca please create a PR in order to I see which files are impacted (is java code package is impacted?)

[nelsongraca]

Java package impact should be zero. @angelozerr I will submit a PR in the next hours with the changed needed.

[nelsongraca]

@angelozerr created #352 tests are failing will check now, but this is the main impact.

[nelsongraca]

Tests are now passing.

[esuomi]

@nelsongraca Thank you for creating this patch already in advance :)
@angelozerr When would you estimate to have this merged and released? Considering its urgency for all Java 9+ users having a public snapshot/beta release as soon as possible would do just fine while you assess the wider impact, if any.

Edit: Merging this would also allow you to close #324 and #343 as well as #352 supercedes both of those.

[nelsongraca]

Like @esuomi I would like to have this available ASAP since I'm depending on it to integrate with some projects.

[nelsongraca]

#352 Merged, closing issue, waiting on next release. Thank you.

[esuomi]

Echoing what @nelsongraca said, especially the thanks part! :)