Upgrade POI to 4.0.1 #352
Merged
Upgrade POI to 4.0.1 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@pascalleclercq can you take a look at this one? It would be great to have this merged and in a release. |
angelozerr
reviewed
Feb 14, 2019
...nverter.pdf.itext5/src/test/java/org/apache/poi/xwpf/converter/pdf/PdfConverterTestCase.java
Show resolved
Hide resolved
angelozerr
reviewed
Feb 14, 2019
...xwpf.converter.pdf/src/test/java/org/apache/poi/xwpf/converter/pdf/PdfConverterTestCase.java
Show resolved
Hide resolved
angelozerr
reviewed
Feb 14, 2019
...rter.xhtml/src/test/java/org/apache/poi/xwpf/converter/xhtml/XHTMLConverterEmbedImgTest.java
Show resolved
Hide resolved
angelozerr
reviewed
Feb 14, 2019
...onverter.xhtml/src/test/java/org/apache/poi/xwpf/converter/xhtml/XHTMLConverterTestCase.java
Show resolved
Hide resolved
|
Thanks @nelsongraca ! |
|
@angelozerr Thank you for accepting the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes, I still have test failures, but then I did not build before the changes so I don't know yet if I broke them or they already were, will check after and update the PR if needed.