Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow underline in markdown #273

Closed
brandonopened opened this issue Dec 1, 2017 · 5 comments
Closed

Allow underline in markdown #273

brandonopened opened this issue Dec 1, 2017 · 5 comments

Comments

@brandonopened
Copy link
Member

No description provided.

@roverwolf
Copy link
Member

Related to #229 which asked the question of what syntax we want to use to add underlining.

#253 added some HTML tags which allows using <u>...</u> to add underlining.

With this issue, did we want to extend the markdown syntax to add a way to do underlining? If so, we need to determine what syntax we want to use.

@BarbAllen
Copy link

Jira #2818

@roverwolf
Copy link
Member

PR #305 now parses _abc_ to be dispalyed with <u> instead of <em>

@jmarks
Copy link
Member

jmarks commented Jan 8, 2018

I want to make sure we are not breaking starndard markdown as defined here: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet

Underscore before or after, like "test", is strong emphasis. We should use HTML only for underline OR provide a new Markdown for underline. However, neither is a great solution.

@roverwolf
Copy link
Member

I think standard markdown would be considered the CommonMark spec.

Underscores before and after normally indicate emphasis (not strong emphasis), which this does break.

What new markdown syntax would you suggest?

One could possibly argue that underlining is a form of emphasis, but the CommonMark spec does specify <em> as the HTML that would be generated (Also note that <u> was deprecated and is technically not "underline" in HTML5).

Please re-open this issue or create a new one if this is a problem as commenting on closed issues is not easily findable and makes it look like the issue is still resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants