Replace CoffeeScript with ES6 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @guidiego! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
guidiego
force-pushed
the
fix/descoffenize
branch
from
474242e
to
294210f
Compare
duduribeiro
requested changes
Oct 27, 2018
There was a problem hiding this comment.
You should remove db/schema.rb file.
Also, please change the commit message. This message don't remind what you did. (also, I don't like this pattern of: Remove: something. The title should be an imperative message explaining what you did. (please read this: https://chris.beams.io/posts/git-commit/#imperative)
use something like:
Replace CoffeeScript with ES6
502df5d
to
cb0d751
Compare
guidiego
force-pushed
the
fix/descoffenize
branch
from
cb0d751
to
d027977
Compare
Remove all .coffe stuff and add webpack to compile ES6
guidiego
force-pushed
the
fix/descoffenize
branch
from
d027977
to
67dfe69
Compare
duduribeiro
approved these changes
Oct 30, 2018
This was referenced Oct 30, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all .coffe stuff and add webpack to compile ES6