Added field of domain company #140
Conversation
|
Hello, @rafaelsevla! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
db/schema.rb
Outdated
| @@ -0,0 +1,58 @@ | |||
| # This file is auto-generated from the current state of the database. Instead | |||
There was a problem hiding this comment.
I'm not sure if this file should be in the repository, could you please confirm @duduribeiro? I think this is a reminiscent of the workaround to run using Docker.
There was a problem hiding this comment.
you are right, this should be removed. @rafaelsevla can you remove this file and recommit again?
There was a problem hiding this comment.
@rafaelsevla also, can you change the commit message?
Please use imperative titles. (look this: https://chris.beams.io/posts/git-commit/#imperative)
In this case, you should use:
Add domain field for Company
delete schemas because this file should not be in the repository
|
@rafaelsevla I'd rather prefer a rebase instead of creating a new commit removing the |
|
@samuelgrigolato I can approve and squash both commits via Github (and also change the commit message). WDYT? |
|
Indeed, squashing the commits should be enough for keeping the history in a clean state. Works for me! |
dominio da empresa nos campos de criação