Tantivy index #149
Merged
Tantivy index #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To my mind, one of the next steps here could be swapping out the tokenizer for a custom routine. The NK tokenizer does a ton of things that may not at all be needed, and I'd rather rely on how the tantivy people did it. We might want to keep transliteration and a few bits of normalisation in place, but more on a per-type basis :) |
|
Agreed. I just want to spend a little bit of time identifying why some of the entities we're not matching are missing - if they're dropping out because they're not coming up as candidates, or some bug somewhere. But definitely want to make better use of the tokenisation available in tantivy |
It's giving results as if only one term needs to match, and multiple matches aren't scoring high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.