-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NPM lock file v2 #242
base: main
Are you sure you want to change the base?
Add support for NPM lock file v2 #242
Conversation
Signed-off-by: ahmed saber <ahmedsaberwd@gmail.com>
Hey @asaberwd @RodneyRichardson is this PR still alive (and planning on merging into a soon-ish version)? I'd love to use this to generate an SBOM for an application I'm building. |
Sorry, I don't know - I was just poking my nose in and commenting! |
@alexthemark sorry Alex i made the fix but have no idea if the maintainers of the project still working on it or accepting any new changes. |
@asaberwd, the build is failing. |
@colek42 I'll take a look. I disabled CI builds for now, but this PR may fix it. |
@asaberwd Will you be able to resolve the conflicts? If you can I will merge it. |
@nishakm I'll have something ready in a few days. |
Signed-off-by: Ahmed Saber <ahmedsaberwd@gmail.com>
@nishakm conflicts resolved |
@asaberwd I'm getting an error when running the tool on the npm test app:
I think this is unrelated to your changes. But take a look at the fix to see if that will solve the issue: #277 |
Signed-off-by: ahmed saber ahmedsaberwd@gmail.com
Fix issue #231 adding support for NPM lock file version 2
@niravpatel27