Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribute local changes to upstream #297

Conversation

Hashawaji
Copy link

I used this repository to generate SBOMs for my organization. I faced some issue for which I did some fixes in my fork. This PR contains those changes to contribute to upstream.

pkg/format/format.go:
This change adds license information for packages.
related issue: #145

pkg/modules/npm/handler.go:
These changes were added to support package-lock v2 files
related issue: #231

Signed-off-by: Hashim Javed hashawaji@gmail.com

Signed-off-by: Hashim Javed <61267519+Hashawaji@users.noreply.github.com>
@Hashawaji
Copy link
Author

@nishakm Please have a look and do let me know if there is a community meeting tomorrow, I would love to participate and discuss these changes.

@ba11b0y
Copy link
Contributor

ba11b0y commented Aug 8, 2023

Hey! @Hashawaji
We're trying to do a complete refactor of the sbom generator project. In the proposed refactor we're trying to use the parsers project and the tools-golang combined.

This PR houses the refactor as of now.
Maybe you can try generating the SBOM using the PR, and if you still face the same issue you can send in a PR to the npm parser since eventually we'll end up using that

@Hashawaji Hashawaji closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants