card-atrust-acos should be renamed to card-acos

[mtausig]

The driver for smartcards Mentioned in the title are named incoreectly. ACOS is the operationg system of the card (produced by AustriaCard), atrust is the name of an Austrian CA which only uses these cards.
To be in accordance with the other naming schemes, the driver should be renamed to card-acos.

[frankmorgner]

Do you have a reference for this?

[mtausig]

It is stated on the website of AustriaCard, that ACOS is their product: http://austriacard.at/acarticle.jsp?M=M3_5
And a reference to the A-Trust homepage with a statement that they are using the ACOS operating system: https://www.a-trust.at/ATrust/Produkte/asignPremium.aspx (link is german)

[martinpaljak]

So do folks at ACS have an operating system ACOS. Thus the name is too generic for that. I'd better name it "card-austriacard" (and assume that their product family is named/compatible with acos also in the future as well)

[frankmorgner]

Are there other chip os's that implement the austria card?

Is card-atrust-acos.c related to card-acos5.c?

[mtausig]

Wouldn't that be rather inconsistent? All the other card drivers are named after the name of the OS ( like CardOS), and not after the company producing it. Which is a good thing, since companies change more frequently than OS-names.
So I rest with my suggestion to name it card-acos.

Am 23. Oktober 2014 14:24:00 MESZ, schrieb Martin Paljak notifications@github.com:

So do folks at ACS have an operating system ACOS. Thus the name is too
generic for that. I'd better name it "card-austriacard" (and assume
that their product family is named/compatible with acos also in the
future as well)

---

Reply to this email directly or view it on GitHub:
#112 (comment)

[frankmorgner]

There is already card-acos5.c for "ACS ACOS5". I guess the naming card-atrust-acos.c was used to avoid confusions.

As compromise and for consistency, what about renaming card-acos5.c to card-acs-acos5.c? This thread is already way too long for a problem thats non-existing!

[martinpaljak]

@frankmorgner +1 for a non-problem :)

[frankmorgner]

I was just about to rename the file... Then I saw that card-acos5.c and card-atrust-acos.c were created 2005 and 2007. Since nobody complained since then it seems not nessaccary to change it now. We leave it as "won't fix" for historical reasons.