Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VW Beetle again #16

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Add VW Beetle again #16

merged 2 commits into from
Jul 10, 2022

Conversation

t-paul
Copy link
Member

@t-paul t-paul commented Jul 9, 2022

No description provided.

UBaer21
UBaer21 approved these changes Jul 9, 2022
View reviewed changes
Copy link

@UBaer21 UBaer21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

site checked, image checked.

@t-paul t-paul requested a review from rcolyer July 9, 2022 19:14
UBaer21
UBaer21 requested changes Jul 9, 2022
View reviewed changes
Copy link

@UBaer21 UBaer21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems there is a different image on the website for it
http://www.commandermodel.com/articles/projects/Beetle.prototype.2/openscad_exploded_view.png

@t-paul t-paul merged commit 0a3027b into main Jul 10, 2022
@t-paul t-paul deleted the add-vw-beetle branch July 10, 2022 19:41
@solidboredom
Copy link
Collaborator

Thorsten, really sorry for spamming here, i find no other way to contact you, could you add the constructive lib to the Library list? i have lost your email. very happy to see this deleted after read. Peter

@t-paul
Copy link
Member Author

t-paul commented Jul 13, 2022

Makes sense, I'll move it to the library list, it certainly fits all the critera (open source + good documentation). And I can use the removal in the gallery for another try with auto-merge 😀.

For reaching out, you can also use the IRC channel (link on the homepage in the news ticker on top).

@t-paul
Copy link
Member Author

t-paul commented Jul 13, 2022

Added to the library list. Just asking... is it intentionally GPL-2.0-only? It's totally fine if that's the case, it makes it incompatible with any GPL-3.0 code though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcolyer rcolyer rcolyer approved these changes

@UBaer21 UBaer21 UBaer21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@t-paul @solidboredom @rcolyer @UBaer21