New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2D Convex hull crash in CGAL #1871
Comments
Update from CGAL: convex_hull_2 needs an exact kernel |
I thought OpenSCAD no longer used CGAL for 2D operations? |
In general not, but we haven't found a suitable replacement for 2D convex hulls |
Oh, I thought you had rolled your own. It is very simple in 2D. IIRC you
find an extreme point and then look for the point which creates the biggest
angle to it and so on as you go around the outside.
…On 24 November 2016 at 18:40, Marius Kintel ***@***.***> wrote:
In general not, but we haven't found a suitable replacement for 2D convex
hulls
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1871 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAijhVASPn6WoXdQOh_PSPI0zuTBx2Xiks5rBdoWgaJpZM4K7R6x>
.
|
i would imagine that if you use fixed-width floating point coordinates, then translating and rotating a set of points in space will result in different topology for the hull at different orientations and locations. in other words if you traverse the points of the hull clockwise and print out each point's coordinates, you will get a different list depending on where the object is located in space. |
@donbright That's pretty accurate. Not sure that topology would differ but certainly vertex count and relative position. Otoh, it already does as we perform 2D hulls using floating point coordinates. |
The reported example now works without crashing. |
Reported by @More-Wrong.
See CGAL issue: CGAL/cgal#1703
Stack trace:
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: