Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console cmd+a works, but cmd+c doesn't #4060

Open
3Dietrich opened this issue Jan 20, 2022 · 10 comments
Open

Console cmd+a works, but cmd+c doesn't #4060

3Dietrich opened this issue Jan 20, 2022 · 10 comments

Comments

@3Dietrich
Copy link

3Dietrich commented Jan 20, 2022

OpenSCAD Version 2021.01
OpenSCAD Version 2022.01.20

@ macOS 12.0.1, MBAir 2020 M1

sometimes I want copy something out of the console. for copying I am very used to shortcut 'cmd+c'.
But this doesn't work in console. cmd+a (select all) works, cmd+c doesn't.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ChrisCoxArt
Copy link
Contributor

Yep, looks like we have to use the context (right click) menu to copy text in the console.
Pressing command-c, even after targeting and selecting text in the console, still copies what is selected in the editor.
Looks like the select all behavior is inherited from QT or QScintilla, as OpenSCAD doesn't even have a menu item for it.

@thehans
Copy link
Member

thehans commented Jan 24, 2022

The Console pane is unrelated to QScintilla, it is a Qt QPlainTextEdit widget.
Ctrl-C in the Console works for me on Linux, FWIW.

Sounds like something strange is going on with focus on Mac, where its being forced back to the editor.

@MichaelAtOz
Copy link
Member

MichaelAtOz commented Jan 24, 2022 via email

@RAMilewski
Copy link

On MacOS Mojave and Monterey, neither command-C nor copy from the Edit menu work for me. Copy from the context menu does.

On Ubuntu 20.04 Ctrl-C does, copy from the context menu does, but copy from the Edit menu does not.

@thehans
Copy link
Member

thehans commented Aug 11, 2022

@RAMilewski wrote:

... copy from the Edit menu ...

I'm pretty sure this is intended to copy from the Editor pane only, not the Console. Hence why it doesn't work on Mac nor Linux for you.

@jordanbrown0
Copy link
Contributor

Ctrl+C works from the Console in Windows. (But only when the Console has focus, as hinted by the fact that the highlight goes away when focus moves.)

But Edit/Copy does not.

It is probably relevant that the context menu in the Console has Copy/Ctrl+C and Select All/Ctrl+A on it.

@jordanbrown0
Copy link
Contributor

In Windows, Ctrl+A does work in the Console. (Windows 10, but I doubt that's relevant.)

thehans added a commit to thehans/openscad that referenced this issue Aug 13, 2022
@thehans
Copy link
Member

thehans commented Aug 13, 2022

I think I have a solution to this, in PR #4326. These changes should also allow the Edit->Copy menu to be used on either Editor or Console.

I've only tested on Linux Mint 22. I don't have access to a mac to verify that this fixes the original issue of cmd-c shortcut in Console.
But if @ChrisCoxArt or @3Dietrich can test the build here, then we can get it merged to master and wrap up this issue.

@thehans
Copy link
Member

thehans commented Aug 18, 2022

Or @RAMilewski ... or anyone else with a mac that could test? Bueller?

@3Dietrich
Copy link
Author

3Dietrich commented Aug 18, 2022

Or @RAMilewski ... or anyone else with a mac that could test? Bueller?

YES!
I could copy selected content from the Console Window into an editor. @thehans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants