Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Manifold objects fail to import into Manifold #5022

Closed
kintel opened this issue Feb 28, 2024 · 0 comments · Fixed by #5020
Closed

Some Manifold objects fail to import into Manifold #5022

kintel opened this issue Feb 28, 2024 · 0 comments · Fixed by #5020

Comments

@kintel
Copy link
Member

kintel commented Feb 28, 2024

When importing files into Manifold, we first convert to a polygon soup, and then try to repair it.
This doesn't work for certain types of manifolds, specifically meshes which touch itself in a single face:

https://github.com/openscad/openscad/blob/98c132516a80312604c346557af52fbe7091638f/tests/data/scad/3D/misc/polyhedron-self-touch-face.scad

To fix this, it would be interesting to try to bypass the polygon soup step in cases where the imported object is a valid manifold.
This also happens with polyhedron() definitions, not just imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant