New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain manifoldness when converting between PolySet and ManifoldGeometry #5020
Conversation
@pca006132 This is not mergeable, but could be a starting point for experimentation/discussion. |
Wow this is a pretty large patch, I think we can probably start small and try to construct |
Oh, don't worry, just look at the very last commit. |
b6f178b
to
6e2c822
Compare
Seems fine, not sure how the status thing will interact with multiple threads though (not that it matters now). I think manifold should probably provide some thread safe alternative to check the status, though it may be a hard problem (to keep compatibility). |
What part of the status handling is not thread safe? |
Ah, nevermind, I remembered the wrong API. I thought that status is static but it is not |
30236e9
to
84917c1
Compare
8c84746
to
2aa9568
Compare
2aa9568
to
dfc72b2
Compare
dbafc5a
to
89fbf7a
Compare
@pca006132 If you find the time: The interesting pieces are |
Fixes #5022
ResultObject::mutableResult()
andResultObject::constResult()
to make it more clear what to expect, plus clean up some wrong constness.