-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewport-Control widget can be made too narrow; tab order broken. #5116
Comments
As said in #4706 this is intentional (and probably not possible to solve). |
@t-paul Maybe checkout the branch, build it and take a look at it? There are two issues, as noted, and they are both 100% solved as far as I can tell with a very simple fix for both. |
Of course, see comment there. |
Thanks. Was just surprised at this being closed before the PR was evaluated. |
Yeah, I thought the other one is an issue too, I did not have enough coffee yet to see the PR icon. But that's not a problem, just the PR is fine. |
I'm on the other end of the bleary eyes - just after midnight in my timezone. Time for some Zzzzz. I'll check in tomorrow in case you want some changes to the PR. |
Viewport-Control widget: Limit width to at least dynamic minimum size of widget. Add tab order back in. Fixes #5116
Describe the bug
PR #5107 improved the Viewport-Control widget by allowing it to morph to a vertical layout when the widget became too narrow for the original horizontal layout.
However after that change the widget could be made too narrow (issue 1) and look bad because the controls were "cut off" and only partially visible. #5107 also lost the left-to-right top-to-bottom tab order within the widget (issue 2). This PR fixes both of these issues.
To Reproduce issue 1 - widget may be made too narrow
Expected behavior issue 1
The widget width should be constrained to be at least the minimum width necessary to fit the contents and avoid cutting off any of the controls in the window.
To Reproduce issue 2 - tab order is weird
Screenshots
Issue 1 - Viewport-Control can be made too narrow:
Issue 2 - Viewport-Control tab order is weird:
Environment and Version info (please complete the following information):
The text was updated successfully, but these errors were encountered: