Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport-Control widget can be made too narrow; tab order broken. #5116

Closed
haikusw opened this issue Apr 29, 2024 · 6 comments
Closed

Viewport-Control widget can be made too narrow; tab order broken. #5116

haikusw opened this issue Apr 29, 2024 · 6 comments

Comments

@haikusw
Copy link
Contributor

haikusw commented Apr 29, 2024

Describe the bug
PR #5107 improved the Viewport-Control widget by allowing it to morph to a vertical layout when the widget became too narrow for the original horizontal layout.

However after that change the widget could be made too narrow (issue 1) and look bad because the controls were "cut off" and only partially visible. #5107 also lost the left-to-right top-to-bottom tab order within the widget (issue 2). This PR fixes both of these issues.

To Reproduce issue 1 - widget may be made too narrow

  1. Open a new document in OpenSCAD.
  2. If the Viewport-Control isn't visible, select "Viewport-Control" from the Window menu
  3. If the Viewport-Control isn't in the right size of the Window, move it there.
  4. Resize the Viewport-Control widget to as small as you can get it.
  5. Notice that its contents are no longer fully visible (screenshot below).

Expected behavior issue 1
The widget width should be constrained to be at least the minimum width necessary to fit the contents and avoid cutting off any of the controls in the window.

To Reproduce issue 2 - tab order is weird

  1. Open a new document in OpenSCAD.
  2. If the Viewport-Control isn't visible, select "Viewport-Control" from the Window menu
  3. Set the focus to the first control in the Viewport-Control widget: Aspect Ratio.
  4. Hit the tab key repeatedly and watch the focus jump around in the widget in a less than useful order.

Screenshots
Issue 1 - Viewport-Control can be made too narrow:

image

Issue 2 - Viewport-Control tab order is weird:

Screen Recording 2024-04-28 at 11 25 07 PM 2024-04-28 23_27_18

Environment and Version info (please complete the following information):

@t-paul
Copy link
Member

t-paul commented Apr 29, 2024

As said in #4706 this is intentional (and probably not possible to solve).

@t-paul t-paul closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
@haikusw
Copy link
Contributor Author

haikusw commented Apr 29, 2024

@t-paul Maybe checkout the branch, build it and take a look at it? There are two issues, as noted, and they are both 100% solved as far as I can tell with a very simple fix for both.

@t-paul
Copy link
Member

t-paul commented Apr 29, 2024

Of course, see comment there.

@haikusw
Copy link
Contributor Author

haikusw commented Apr 29, 2024

Thanks. Was just surprised at this being closed before the PR was evaluated.

@t-paul
Copy link
Member

t-paul commented Apr 29, 2024

Yeah, I thought the other one is an issue too, I did not have enough coffee yet to see the PR icon. But that's not a problem, just the PR is fine.

@haikusw
Copy link
Contributor Author

haikusw commented Apr 29, 2024

I'm on the other end of the bleary eyes - just after midnight in my timezone. Time for some Zzzzz. I'll check in tomorrow in case you want some changes to the PR.

t-paul added a commit that referenced this issue May 14, 2024
Viewport-Control widget: Limit width to at least dynamic minimum size of widget. Add tab order back in.  Fixes #5116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants