Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad STL generated from relatively simple model #541

Closed
Claghorn opened this issue Nov 9, 2013 · 11 comments
Closed

Bad STL generated from relatively simple model #541

Claghorn opened this issue Nov 9, 2013 · 11 comments

Comments

@Claghorn
Copy link

Claghorn commented Nov 9, 2013

Using openscad-2013.06-5.fc19.x86_64 from the fedora linux repos, I created what I thought was a pretty simply model. The most complicated thing it did was subtract an imported STL file from the inside of a cylinder shape. When attempting to slice the resulting model, slic3r generated wacky gcode, and kisslicer generated different wacky gcode, but also reported issues like degenerate triangles and other problems.

The files in question are available here: http://home.comcast.net/~tomhorsley/hardware/solidoodle/solidoodle-pcbvise.html

and some additional discussion is found here: http://www.soliforum.com/topic/4473/just-had-my-first-slic3r-screwup/

Just thought I'd report it in case someone wanted to look at it. It did generate a problem free model when I was using a pure cylinder. When I tried to make the top half a very very slight cone shape is when the generated STL went haywire.

https://github.com/openscad/openscad/blob/5affb45eb36943c6b1e5909b3904b7426ab00d22/testdata/scad/bugs/issue541.scad
screen shot 2014-01-05 at 12 26 20 pm

@kintel
Copy link
Member

kintel commented Nov 9, 2013

The STL appears to be the culprit. The following file crashes OpenSCAD when fed the STL in question:
render() import("/Users/kintel/Downloads/PCBviseBar.stl");

@Claghorn
Copy link
Author

Claghorn commented Nov 9, 2013

I can certainly believe that, but I guess I didn't think of it since I had no problems using the STL when I had just a cylinder. I now see that kisslicer does report problems with the bar when I open it. Thanks for taking a look at it.

@kintel
Copy link
Member

kintel commented Nov 9, 2013

We do have some robustness issues when importing STLs, so this is a good example of such a case. Not sure what can be done about it, but at least better reporting, perhaps light-weight automatic repair.
I'll eventually open a new issue on this..

@hroncok
Copy link
Contributor

hroncok commented Nov 9, 2013

Maybe use admesh for reporting and/or repair?

@kintel
Copy link
Member

kintel commented Nov 9, 2013

Admesh is on the radar. I think Slic3r uses admesh-based repair of STL files.

@GilesBathgate
Copy link
Contributor

It might be a good idea to put admesh in the testing pipeline and see if the export from openscads various tests produces stl with errors reported by admesh.

@kintel
Copy link
Member

kintel commented Dec 1, 2013

@kintel
Copy link
Member

kintel commented Dec 1, 2013

From @nophead: NetFabb studio shows degenerate faces (of the example posted above)

@kintel
Copy link
Member

kintel commented Dec 1, 2013

Perhaps this can be improved by doing a delaunay re-evaluation before exporting, as discussed recently on the mailing list (http://forum.openscad.org/STL-export-and-triangulation-td6010.html).

@kintel
Copy link
Member

kintel commented Dec 1, 2013

The crash aspects of this issue was fixed in #410 - the remaining issue is about failure to export STL and render in preview mode due to the Nef_polyhedron -> Polyhedron3 conversion error.

@kintel
Copy link
Member

kintel commented May 17, 2014

This was fixed sometime during unstable refactoring. Should be fixed in the development snapshot builds

@kintel kintel closed this as completed May 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants