Stack usage optimization for tostream_visitor #4182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was tested against the sample code in #4172, and while it does not fix the crash, it delays the crash until higher values of
b
, by going through fewer function calls, and re-usingtostream_visitor
instead of constructing new ones for each nested vector.My testing showed the lowest value to trigger a crash went up by about 1000 after changes.
Lowest b value required to trigger a crash, built with
g++-10
Also removed some
Value::toString|toStream
functions which were not being used.