New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for many clang-tidy bugprone-*
checks
#4464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `RangeType::type_t` enum to `iter_state` for clarity.
Qt's Keys and Modifier enums are not same types, but are necessarily bitwise OR'd for setting shortcuts.
libsvg derived class member function names are similar to parent class' `get_x()` and `get_y()`, but not by mistake.
I noticed that base Geometry class copy constructor would handle copying `convexity`, and thought this might be related to issue openscad#4115 This did not actually fix the issue, but... (see next commit).
Pretty sure this call to grandparent class' member function is intended.
…conversions` (hundreds more remain)
…lus.NewDeleteLeaks`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some counts of unique lines which failed
bugprone
checks before:after:
The remaining checks are disabled in the top-level
.clang-tidy
file:narrowing-conversions
were just too many to deal witheasily-swappable-parameters
This is triggered any time two or more parameters of the same type are adjacent in a function signature, for example anything of the form:foo(T x,T y,T z)
. I don't see any sensible way to avoid such occurrences.exception-escape
these should probably be looked into, but I'm not sure how to best handle them. The offending lines are pasted below.