New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Textures for OpenSCAD Preview mode #4551
Open
gsohler
wants to merge
172
commits into
openscad:master
Choose a base branch
from
gsohler:textures
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improved primitives testcase
m# Please enter the commit message for your changes. Lines starting
(void) jpeg_read_header(&cinfo, TRUE); | ||
(void) jpeg_start_decompress(&cinfo); | ||
row_stride = cinfo.output_width * cinfo.output_components; | ||
img_buf=(unsigned char *) malloc(cinfo.output_width*cinfo.output_height*cinfo.output_components); |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type
Multiplication result may overflow 'unsigned int' before it is converted to 'size_t'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets make Preview output more artful and introduce textures
WIP, CGAL Render is known not to work correctly, tests will fail there
Pictures tell more than a 1000 words ...
https://imgpile.com/i/hUiByM