Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored all the various GL error checking macros #4570

Merged
merged 6 commits into from Mar 23, 2023
Merged

Refactored all the various GL error checking macros #4570

merged 6 commits into from Mar 23, 2023

Conversation

kintel
Copy link
Member

@kintel kintel commented Mar 21, 2023 •
edited

Moved into common macros in system-gl.h

TODO:

  • Decide on naming of the macros
  • Check if existing usage is using the desired macro variant
  • Look into supporting GL tracing as well -> let's do this later if needed.

@kintel kintel force-pushed the kintel-glcheck branch 3 times, most recently from 4e6c134 to a0a86ee Compare March 22, 2023 21:31
@kintel kintel marked this pull request as ready for review March 23, 2023 01:30
@kintel kintel merged commit 40f973e into master Mar 23, 2023
8 checks passed
@kintel kintel deleted the kintel-glcheck branch March 23, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kintel @t-paul