Turn simplify_function_body into a virtual method #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kintel
reviewed
Jun 6, 2023
| @@ -567,7 +564,7 @@ Value FunctionCall::evaluate(const std::shared_ptr<const Context>& context) cons | |||
| const Expression *expression = this; | |||
| while (true) { | |||
| try { | |||
| auto result = simplify_function_body(expression, *expression_context); | |||
| auto result = expression->simplify_function_body(*expression_context); // || Value::undefined.clone() | |||
There was a problem hiding this comment.
What's the purpose of the commented out code?
| { | ||
| if (!expression) { | ||
| const auto *call = this; |
There was a problem hiding this comment.
Nit: Apart from retaining the old structure, does the call variable make this more readable, or does it makes sense to just use this?
|
Didn't realize this was still a draft. Looks like a decent refactor to me. |
|
Does this not increase sizeof (Expression) for all expressions |
OK Apologies for the noise. . It shouldnt https://stackoverflow.com/questions/63557630/why-the-size-of-class-remains-same-on-adding-more-than-one-virtual-function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.