GSoC 2023: Create VertexStateManager #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kintel
reviewed
Jun 21, 2023
jbinvnt
commented
Jul 7, 2023
jbinvnt
force-pushed
the
gsoc-2023-create-vsm
branch
2 times, most recently
from
5d23d29
to
20b3978
Compare
jbinvnt
force-pushed
the
gsoc-2023-create-vsm
branch
from
20b3978
to
34dcef1
Compare
jbinvnt
force-pushed
the
gsoc-2023-create-vsm
branch
from
44a838e
to
8594cda
Compare
kintel
approved these changes
Jul 18, 2023
t-paul
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VertexStateManageris a class for holding common logic used by multiple renderer classes. This reduces duplicate code and is expected to provide a single place where future changes to OpenGL operation will propagate across different types of renderers.The intended use case for this class is to be a drop-in replacement for logic that currently makes certain rendering functions long and redundant. Therefore
VertexStateManagerobjects are initialized with references to stack objects. This means that lifetime of avsmshould be limited to the scope of the function in which it is created.Future refactoring might repurpose
VertexStateManagerinto a larger hierarchy of classes. For now though, its goal is to accelerate ongoing investigation of OpenGL modernization by allowing the multiple rendering modes to share individual functions.This pull request does not introduce any functional changes to the codebase. More PRs will follow for Google Summer of Code 2023.