New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename --render=cgal to --render=force to force-convert to the current backend-specific geometry #4822
Conversation
626d7ac
to
90a8804
Compare
Yes, you should rename it. "--render=cgal" should use CGAL, or be an error if CGAL is not available. Otherwise it's confusing. |
I believe the initial purpose of this flag was:
Ideally, we should rename If we do ship with multiple backends (either for a release build or as experimental), having a flag to select backend would make sense, but that could be separate from |
90a8804
to
d53e470
Compare
Update: Renamed |
d53e470
to
9ac6ef4
Compare
f150290
to
bc1145b
Compare
…urrent backend-specific geometry
…ate mutable objects
bc1145b
to
b23bc8a
Compare
--render=cgal
was really meant for converting to the internal format of the current geometry engine to utilize any of its built-in mesh validation and repair tools. When using another geometry backend, we're changing this to--render=force
to force conversion into the current backend-specific geometry.--render=cgal
is still useable for backwards compatibility, but not sure for how much longer we need to support it.Also added some opportunistic refactoring.