-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More options and usability improvements for Surface #4964
base: master
Are you sure you want to change the base?
Conversation
… surface with thickness and option to skip pixels to make it quicker to compute.
…o SurfaceImprovements
I wondering if it would be a better strategy having a new module with a more obvious interface so at some point later |
That sounds like a good option. I would gladly refactor this PR to make it a new module. Did you already have a name and signature in mind?
This would also add a size parameter to make the size of the resulting object independent of the given file. The z value of that size I would interpret as the difference between the resulting z value of a "white" and a "black" pixel. Thickness would then be added to it on the bottom. This makes it very explicit what the resulting geometry looks like. |
I agree that a new module makes more sense. API design is hard though. Some notes:
|
I'd need to look more at surface to have a real opinion on replacing it, but I suggest that the first parameter be either a string filename or an array of values, with everything else defaulting, so that you could say |
Hi all,
for a 3D printing project I needed to add texture to some surfaces. When I started I noticed that Surface was weirdly unpredictable in its sizes, making it virtually unusable for me. Also it was too slow with the heightmaps I'm using. That's ok for compiling STLs, but not really for preview.
So I started diving into the code and adjusting it to my needs. The results are in this PR. Even though this is slightly breaking existing behavior I wanted to see if you would agree that this is making more sense.
Also, part of this can be incorporated without changing behavior of existing scripts.
Changed behavior:
Added features: