Added documentation for installing Command Line Tools #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added some comments - the instructions are an odd mix of using Linux, Windows and macOS tools to install dependencies on macOS. Needs to either be cleaned up, or split up into sections for each OS. |
kintel
reviewed
Feb 18, 2024
| @@ -141,8 +141,38 @@ To pull the various submodules (incl. the [MCAD library](https://github.com/open | |||
| Prerequisites: | |||
|
|
|||
| * Xcode | |||
| Terminal tools | |||
| * In terminal, run: brew install automake | ||
| libtool | ||
| * In terminal, run: brew install libtool | ||
| * May have to use "glibtool" instead on some newer versions of MacOSX |
There was a problem hiding this comment.
Could you explain this a bit better? On what version of macOS is glibtool available on homebrew?
| * Install using: sudo mkdir /opt/cmake | ||
| * Finish install; sudo sh <installer filename> --prefix=/opt/cmake | ||
| * Common issues with cmake: version too outdated or filepaths contain unecessary spaces | ||
| * If issues persist, visit this resource https://hsf-training.github.io/hsf-training-cmake-webpage/07-commonproblems/index.html |
There was a problem hiding this comment.
The cmake instructions seem to be a mixture or macOS and Linux instructions. Why would we use apt purge on macOS?
| * Common error returned: "error cannot open file '_____.lib'" | ||
| * To address this, make sure the proper language is installed | ||
| * Ex.: for C++ projects, install Visual C++ for Desktop Development | ||
| * In Visual Studio: Installed > Change Installed VS CE > Workloads > Desktop Development with C++ > apply and save |
There was a problem hiding this comment.
Why mention Visual Studio in macOS install instructions?
|
Closing due to lack of feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added documentation describing how to install automake, libtool, cmake, pkg-config, wget, and meson and included some common pitfalls and solutions for those processes. This will improve contributors' understanding because the installation prerequisites are more explicitly explained.